Bug 19833
| Summary: | REGRESSION(r34754): Start profile button in profiler now profiles inspector rather than actual page | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, darin, kmccullough, timothy |
| Priority: | P1 | Keywords: | InRadar, Regression |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
| URL: | http://nerget.com/ParticleJS/Particles.html | ||
Oliver Hunt
I just found that when starting a profile by clicking the button to start profiles in the inspector results in us reporting profile data for the inspector which seems wholly unhelpful.
To reproduce
* Go to http://nerget.com/ParticleJS/Particles.html
* Open the inspector
* Go to the profile pane
* Click the profile button
* Wait a wee while
* Stop the profile
* Admire the profile of the inspector.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kevin McCullough
rdar://problem/6067178
Kevin McCullough
It looks like r34753 is the culprit.
Adam Barth
I'll take a look at this tonight.
Kevin McCullough
Although that revision does not look like it could have possibly caused the issue. I think the inspector needs to call startUserInitiatedProfiling() instead of console.profile();
Kevin McCullough
Scratch that calling InspectorController.inspectedWindow().console should contextually be correct in that it should call the console on the inspected window.
Adam Barth
> It looks like r34753 is the culprit.
Hum... I can't repro the bug at r34753 but I can repro it at r34754.
http://trac.webkit.org/changeset/34754
That change seems more relevant as touches lines of code that actually run in this case.
Kevin McCullough
Yeah I re-ran my tests and I also think r18754 is the real culprit. Sorry to waste your time. I just need to figure out how this caused the regression.
Kevin McCullough
I'm guessing that somewhere under JSInspectedObjectWrapper::wrapone of these wrappers is holding the wrong ExecState.
Kevin McCullough
Committed revision 35140.