Bug 198322

Summary: Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
Product: WebKit Reporter: Justin Michaud <justin_michaud>
Component: JavaScriptCoreAssignee: Justin Michaud <justin_michaud>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dean_johnson, msaboff, saam, sroberts, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch
none
Patch none

Justin Michaud
Reported 2019-05-28 19:03:20 PDT
Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
Attachments
Patch (3.43 KB, patch)
2019-05-28 19:05 PDT, Justin Michaud 		no flags
DetailsFormatted DiffDiff
patch (3.43 KB, patch)
2019-05-28 19:49 PDT, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Patch (3.47 KB, patch)
2019-05-29 16:18 PDT, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Justin Michaud
Comment 1 2019-05-28 19:05:50 PDT
Created attachment 370822 [details] Patch
Justin Michaud
Comment 3 2019-05-28 19:49:00 PDT
Created attachment 370824 [details] patch Rubber stamped by Saam
WebKit Commit Bot
Comment 4 2019-05-28 20:27:54 PDT
Comment on attachment 370824 [details] patch Clearing flags on attachment: 370824 Committed r245843: <https://trac.webkit.org/changeset/245843>
WebKit Commit Bot
Comment 5 2019-05-28 20:27:55 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 6 2019-05-29 13:14:09 PDT
We're still seeing 7 test timeouts after this change: ** The following JSC stress test failures have been introduced: wasm.yaml/wasm/function-tests/context-switch.js.wasm-collect-continuously wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-collect-continuously wasm.yaml/wasm/function-tests/memory-alignment.js.wasm-collect-continuously wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-collect-continuously wasm.yaml/wasm/js-api/Instance.imports.exports.unicode.js.wasm-collect-continuously wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-collect-continuously wasm.yaml/wasm/js-api/export-arity.js.wasm-collect-continuously https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/2902
Radar WebKit Bug Importer
Comment 7 2019-05-29 13:14:25 PDT
<rdar://problem/51233848>
Justin Michaud
Comment 8 2019-05-29 16:18:09 PDT
Reopening to attach new patch.
Justin Michaud
Comment 9 2019-05-29 16:18:09 PDT
Created attachment 370895 [details] Patch
Justin Michaud
Comment 10 2019-05-29 16:19:16 PDT
Comment on attachment 370895 [details] Patch Rubber stamped by Michael Saboff. Disable running the new collectContinuously tests on debug builds. This matches what we do for other jsc tests.
WebKit Commit Bot
Comment 11 2019-05-29 16:54:04 PDT
Comment on attachment 370895 [details] Patch Clearing flags on attachment: 370895 Committed r245879: <https://trac.webkit.org/changeset/245879>
WebKit Commit Bot
Comment 12 2019-05-29 16:54:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.