Summary: | [AppleWin] Assertion failure in defaultSupportedImageTypes in UTIRegistry.cpp | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||||
Component: | Platform | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, don.olmstead, ews-watchlist, pvollan, ross.kirsling, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Fujii Hironori
2019-05-28 02:12:40 PDT
Created attachment 370719 [details]
Patch
Comment on attachment 370719 [details] Patch Attachment 370719 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12306929 New failing tests: fast/events/mouse-cursor-image-set.html fast/events/mouse-cursor.html fast/images/favicon-as-image.html http/tests/security/canvas-remote-read-remote-video-allowed-with-credentials.html fast/images/icon-0colors.html fast/images/icon-decoding.html http/tests/misc/favicon-as-image.html Created attachment 370725 [details]
Archive of layout-test-results from ews212 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
(In reply to Build Bot from comment #2) > Comment on attachment 370719 [details] > Patch > > Attachment 370719 [details] did not pass win-ews (win): > Output: https://webkit-queues.webkit.org/results/12306929 > > New failing tests: > fast/events/mouse-cursor-image-set.html > fast/events/mouse-cursor.html > fast/images/favicon-as-image.html > http/tests/security/canvas-remote-read-remote-video-allowed-with-credentials. > html > fast/images/icon-0colors.html > fast/images/icon-decoding.html > http/tests/misc/favicon-as-image.html I am not sure why these tests are failing. Maybe the bots support these image types? Created attachment 378623 [details]
Patch
Comment on attachment 378623 [details]
Patch
Win EWS tests passed!
Per, do you have a chance to review this patch? Comment on attachment 378623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378623&action=review This seems reasonable. > Source/WebCore/platform/graphics/cg/ImageSourceCGWin.cpp:-41 > - // public.xbitmap-image, com.apple.quicktime-image, and others. Do we really need to remove this comment? Comment on attachment 378623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378623&action=review >> Source/WebCore/platform/graphics/cg/ImageSourceCGWin.cpp:-41 >> - // public.xbitmap-image, com.apple.quicktime-image, and others. > > Do we really need to remove this comment? Ok, will restore. Created attachment 378931 [details]
Patch for landing
Committed r249938: <https://trac.webkit.org/changeset/249938> After this change, AppleWin Debug buildbot completed running layout tests! https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Tests%29/builds/2866 > 32 failures 388 new passes 7 flakes |