Bug 198283
| Summary: | [JSC] Enable 16bit CLoop Win | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> |
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Yusuke Suzuki
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yusuke Suzuki
Windows CLoop in MSVC is half-broken state right now. MSVC can compile it, the semantics of the compiled CLoop::execute seems fine. The problem is, not sure why, MSVC compiled CLoop::execute requires massive amount of stack space... I don't check it carefully, but inserting some currentStackPointer() and diffing the values say CLoop::execute takes almost 100KB stack space. It does not make sense, CLoop::execute should take very few amount of stack space.
This leads to very easy stack overflow everywhere. If you call CLoop::execute in a nested manner (maybe) 10 times, then you will see stack-overflow range error will be thrown.
I think we should rather switching to LLInt ASM interpreter for Windows.
Radar WebKit Bug Importer
<rdar://problem/128344991>
Yusuke Suzuki
Pull request: https://github.com/WebKit/WebKit/pull/28767
EWS
Committed 278968@main (2c77a224cdd2): <https://commits.webkit.org/278968@main>
Reviewed commits have been landed. Closing PR #28767 and removing active labels.