Bug 198282

Summary: [LFC][IFC] Decouple line layout and processing inline runs.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

zalan
Reported 2019-05-27 21:33:21 PDT
So that we could use the inline run processing logic for preferred width computation too.
Attachments
Patch (12.27 KB, patch)
2019-05-27 21:36 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (12.30 KB, patch)
2019-05-27 21:37 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (12.30 KB, patch)
2019-05-28 07:55 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2019-05-27 21:36:17 PDT
Created attachment 370712 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-05-27 21:36:31 PDT
<rdar://problem/51167954>
Radar WebKit Bug Importer
Comment 3 2019-05-27 21:37:18 PDT
<rdar://problem/51167959>
zalan
Comment 4 2019-05-27 21:37:22 PDT
Created attachment 370713 [details] Patch
Antti Koivisto
Comment 5 2019-05-28 02:38:08 PDT
Comment on attachment 370713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370713&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:62 > + unsigned createInlineRunsForLine(Line&, unsigned firstInlineItemIndex) const; Not super clear what the return value means.
zalan
Comment 6 2019-05-28 07:54:01 PDT
(In reply to Antti Koivisto from comment #5) > Comment on attachment 370713 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370713&action=review > > > Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:62 > > + unsigned createInlineRunsForLine(Line&, unsigned firstInlineItemIndex) const; > > Not super clear what the return value means. Yeah, you are right. I'll address this in the next patch!
zalan
Comment 7 2019-05-28 07:55:10 PDT
Created attachment 370739 [details] Patch
WebKit Commit Bot
Comment 8 2019-05-28 08:36:11 PDT
Comment on attachment 370739 [details] Patch Clearing flags on attachment: 370739 Committed r245812: <https://trac.webkit.org/changeset/245812>
WebKit Commit Bot
Comment 9 2019-05-28 08:36:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.