| Summary: | iOS: Main frame should be scrollable when pinch zoomed or software keyboard is up | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||||||||||||||||
| Component: | Scrolling | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, koivisto, rniwa, simon.fraser, thorton, wenson_hsieh | ||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=198412 | ||||||||||||||||||||||||||
| Bug Depends on: | 198436 | ||||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Ryosuke Niwa
2019-05-24 23:44:48 PDT
Created attachment 370624 [details]
WIP
Created attachment 370625 [details]
WIP
Comment on attachment 370625 [details] WIP Attachment 370625 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12286121 Number of test failures exceeded the failure limit. Created attachment 370628 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 370625 [details] WIP Attachment 370625 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12286136 New failing tests: compositing/backgrounds/fixed-background-on-descendant.html imported/blink/svg/as-image/overflow-auto.html imported/blink/svg/as-background-image/overflow-auto.html fast/scrolling/rtl-initial-scroll-position.html fast/block/positioning/vertical-rl/fixed-positioning.html imported/blink/fast/overflow/hidden-viewport-y.html svg/overflow/overflow-y-hidden-on-outermost-svg-element.svg fast/block/positioning/rtl-fixed-positioning.html Created attachment 370629 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 370625 [details] WIP Attachment 370625 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12286216 Number of test failures exceeded the failure limit. Created attachment 370631 [details]
Archive of layout-test-results from ews214 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 370625 [details] WIP Attachment 370625 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12286180 New failing tests: compositing/backgrounds/fixed-background-on-descendant.html imported/blink/svg/as-image/overflow-auto.html imported/blink/svg/as-background-image/overflow-auto.html fast/scrolling/rtl-initial-scroll-position.html fast/block/positioning/vertical-rl/fixed-positioning.html imported/blink/fast/overflow/hidden-viewport-y.html svg/overflow/overflow-y-hidden-on-outermost-svg-element.svg fast/block/positioning/rtl-fixed-positioning.html Created attachment 370632 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 370825 [details]
WIP3
Created attachment 370826 [details]
WIP4
Created attachment 371000 [details]
Fixes the bug
Created attachment 371024 [details]
Fixed a bug
Comment on attachment 371024 [details] Fixed a bug View in context: https://bugs.webkit.org/attachment.cgi?id=371024&action=review > LayoutTests/fast/scrolling/ios/body-overflow-hidden-height-100-percent-keyboard.html:24 > + // FIXME: Work around the bug that scrolling down after the software keyborad is brought up for the very first time does not work. keyborad You should file a bug and reference it here. > LayoutTests/fast/scrolling/ios/body-overflow-hidden-height-100-percent-keyboard.html:36 > + await new Promise((resolve) => setTimeout(resolve, 100)); UIHelper.delayFor() > LayoutTests/fast/scrolling/ios/body-overflow-hidden-height-100-percent-zoomed-1.html:31 > + await new Promise((resolve) => setTimeout(resolve, 200)); UIHelper.delayFor() > LayoutTests/fast/scrolling/ios/body-overflow-hidden-height-100-percent-zoomed-2.html:35 > + await new Promise((resolve) => setTimeout(resolve, 200)); UIHelper.delayFor Thanks for the review! (In reply to Simon Fraser (smfr) from comment #16) > Comment on attachment 371024 [details] > Fixed a bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371024&action=review > > > LayoutTests/fast/scrolling/ios/body-overflow-hidden-height-100-percent-keyboard.html:24 > > + // FIXME: Work around the bug that scrolling down after the software keyborad is brought up for the very first time does not work. > > keyborad > > You should file a bug and reference it here. Will do. > > LayoutTests/fast/scrolling/ios/body-overflow-hidden-height-100-percent-keyboard.html:36 > > + await new Promise((resolve) => setTimeout(resolve, 100)); > > UIHelper.delayFor() Oh, that's a neat function! Will fix this and the rest. Created attachment 371032 [details]
Patch for landing
Comment on attachment 371032 [details]
Patch for landing
Wait for iOS EWS bot.
Committed r245953: <https://trac.webkit.org/changeset/245953> Re-opened since this is blocked by bug 198436 Committed r245989: <https://trac.webkit.org/changeset/245989> |