Bug 198236

Summary: Update sandbox rules for more News use cases
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, pvollan, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+, ap: commit-queue-

Brent Fulgham
Reported 2019-05-24 15:30:20 PDT
Update the WebContent and Network process sandboxes so that News has the same set of allowed service access as regular WebKit views.
Attachments
Patch (4.15 KB, patch)
2019-05-24 15:33 PDT, Brent Fulgham 		ap: review+
ap: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2019-05-24 15:30:53 PDT
<rdar://problem/50054027>
Brent Fulgham
Comment 2 2019-05-24 15:33:27 PDT
Created attachment 370597 [details] Patch
Alexey Proskuryakov
Comment 3 2019-05-24 16:58:38 PDT
Comment on attachment 370597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370597&action=review > Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:46 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 || PLATFORM(IOSMAC) Please remove most of these #ifs. 10.13 is the minimum.
Brent Fulgham
Comment 4 2019-05-28 10:32:54 PDT
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 370597 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370597&action=review > > > Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:46 > > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 || PLATFORM(IOSMAC) > > Please remove most of these #ifs. 10.13 is the minimum. I don't think that's true until we ship in the fall? 10.14 is current shipping, and we support current and two back.
Brent Fulgham
Comment 5 2019-05-28 10:34:05 PDT
Committed r245817: <https://trac.webkit.org/changeset/245817>
Note You need to log in before you can comment on or make changes to this bug.