Bug 198235

Summary: [WHLSL] Allow vertex attributes to have arbitrary names in the shader
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch dino: review+

Myles C. Maxfield
Reported 2019-05-24 15:27:01 PDT
[WHLSL] Allow vertex attributes to have arbitrary names in the shader
Attachments
WIP (4.61 KB, patch)
2019-05-24 15:27 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (12.97 KB, patch)
2019-05-24 15:47 PDT, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2019-05-24 15:27:18 PDT
Created attachment 370595 [details] WIP
EWS Watchlist
Comment 2 2019-05-24 15:29:12 PDT
Attachment 370595 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 3 2019-05-24 15:47:59 PDT
Created attachment 370599 [details] Patch
Justin Fan
Comment 4 2019-05-24 16:14:45 PDT
Looks good to me!
Myles C. Maxfield
Comment 5 2019-05-24 16:38:26 PDT
Committed r245759: <https://trac.webkit.org/changeset/245759>
Radar WebKit Bug Importer
Comment 6 2019-05-24 16:39:22 PDT
<rdar://problem/51126717>
Note You need to log in before you can comment on or make changes to this bug.