Bug 198218

Summary:

[ews-build] Do not display unnecessary steps in the Buildbot build page UI

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, ews-watchlist, jbedard, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews211 for win-future	none
Patch	none
Patch	jbedard: review+

Aakash Jain

Reported 2019-05-24 05:33:25 PDT

To make the buildbot build page more readable for regular users, we should hide certain steps (especially when they are successful).

Attachments
Patch (1.20 KB, patch) 2019-05-24 05:36 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews211 for win-future (13.59 MB, application/zip) 2019-05-24 09:21 PDT, EWS Watchlist	no flags	Details
Patch (1.69 KB, patch) 2019-06-04 12:20 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Patch (2.01 KB, patch) 2019-06-04 14:12 PDT, Aakash Jain	jbedard: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-05-24 05:33:37 PDT

<rdar://problem/51104544>

Aakash Jain

Comment 2 2019-05-24 05:36:40 PDT

Created attachment 370570 [details] Patch

EWS Watchlist

Comment 3 2019-05-24 09:21:21 PDT Comment hidden (obsolete)

Comment on attachment 370570 [details] Patch Attachment 370570 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12278849 New failing tests: http/tests/css/filters-on-iframes-transform.html fast/shadow-dom/svg-text-path-href-change-in-shadow-tree.html

EWS Watchlist

Comment 4 2019-05-24 09:21:24 PDT Comment hidden (obsolete)

Created attachment 370574 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Jonathan Bedard

Comment 5 2019-05-28 08:42:04 PDT

I'd like to see this active on the UAT environment first. I can see the arguments for it, but there are also some pretty compelling ones against doing something like this. It may hide warnings which were classified as successes but eventually caused a later failure. Something that comes to mind (and has historically been a problem on trunk infrastructure) would be issues with stale SVN files.

Aakash Jain

Comment 6 2019-06-04 12:20:14 PDT

Created attachment 371315 [details] Patch

Aakash Jain

Comment 7 2019-06-04 14:12:21 PDT

Created attachment 371329 [details] Patch

Aakash Jain

Comment 8 2019-06-04 14:27:10 PDT

Committed r246080: <https://trac.webkit.org/changeset/246080>

Note You need to log in before you can comment on or make changes to this bug.