Bug 198207

Summary: Web Inspector: prevent stripping `console.assert` if it's used inside a string
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 195132    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2019-05-23 19:15:32 PDT
``` console.assert(false, "foo"); ``` should be stripped ``` let x = "console.assert(false);" ``` should not be stripped
Attachments
Patch (2.86 KB, patch)
2019-05-23 19:24 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (2.85 KB, patch)
2019-05-23 19:26 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (2.86 KB, patch)
2019-05-23 19:30 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (1.87 KB, patch)
2019-05-23 19:39 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-05-23 19:24:33 PDT
Created attachment 370546 [details] Patch
Devin Rousso
Comment 2 2019-05-23 19:26:16 PDT
Created attachment 370547 [details] Patch
Joseph Pecoraro
Comment 3 2019-05-23 19:28:52 PDT
Comment on attachment 370547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370547&action=review > Source/WebInspectorUI/Scripts/remove-console-asserts.pl:52 > + s/^\s*console\.assert\(.*\);\s*//g; This is nice. I approve this. > Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59 > + next if /^["'`]*console\.assert/; This doesn't do what you think it does.
Devin Rousso
Comment 4 2019-05-23 19:30:49 PDT
Created attachment 370548 [details] Patch
Joseph Pecoraro
Comment 5 2019-05-23 19:33:57 PDT
Comment on attachment 370548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370548&action=review sh > Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59 > + next if /^.*?["'`].*?console\.assert/; /["'`].*?console\.assert/
Joseph Pecoraro
Comment 6 2019-05-23 19:35:11 PDT
Comment on attachment 370548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370548&action=review >> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59 >> + next if /^.*?["'`].*?console\.assert/; > > /["'`].*?console\.assert/ /\/\/.*?console\.assert/
Devin Rousso
Comment 7 2019-05-23 19:39:33 PDT
Created attachment 370553 [details] Patch
WebKit Commit Bot
Comment 8 2019-05-23 20:19:58 PDT
Comment on attachment 370553 [details] Patch Clearing flags on attachment: 370553 Committed r245741: <https://trac.webkit.org/changeset/245741>
WebKit Commit Bot
Comment 9 2019-05-23 20:20:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-05-23 20:20:25 PDT
<rdar://problem/51093853>
Note You need to log in before you can comment on or make changes to this bug.