Web Inspector: prevent stripping `console.assert` if it's used inside a string

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

```
    console.assert(false, "foo");
```
should be stripped


```
    let x = "console.assert(false);"
```
should not be stripped

[Devin Rousso]

Created attachment 370546 [details]
Patch

[Devin Rousso]

Created attachment 370547 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 370547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370547&action=review

> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:52
> +        s/^\s*console\.assert\(.*\);\s*//g;

This is nice. I approve this.

> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59
> +            next if /^["'`]*console\.assert/;

This doesn't do what you think it does.

[Devin Rousso]

Created attachment 370548 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 370548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370548&action=review

sh

> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59
> +            next if /^.*?["'`].*?console\.assert/;

/["'`].*?console\.assert/

[Joseph Pecoraro]

Comment on attachment 370548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370548&action=review

>> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59
>> +            next if /^.*?["'`].*?console\.assert/;
> 
> /["'`].*?console\.assert/

/\/\/.*?console\.assert/

[Devin Rousso]

Created attachment 370553 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 370553 [details]
Patch

Clearing flags on attachment: 370553

Committed r245741: <https://trac.webkit.org/changeset/245741>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51093853>