| Summary: | [iOS] WebPage::positionInformation() may set InteractionInformationAtPosition.isImage to true but leave image unset | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
| Component: | HTML Editing | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 370537 [details]
Patch
Comment on attachment 370537 [details] Patch Attachment 370537 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12274410 New failing tests: editing/selection/character-granularity-rect.html Created attachment 370555 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Comment on attachment 370537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370537&action=review > Source/WebKit/ChangeLog:18 > + Since WebPage::positionInformation() is a little bit difficult to read Hah! I’ve been meaning to do this for years, glad someone finally did. Created attachment 370608 [details]
Patch
Created attachment 370637 [details]
Patch
Comment on attachment 370637 [details]
Patch
This is mostly a rubber-stamp since it's hard to read around the moved code.
Comment on attachment 370637 [details] Patch Clearing flags on attachment: 370637 Committed r245872: <https://trac.webkit.org/changeset/245872> All reviewed patches have been landed. Closing bug. |
One case for this to happen is the image dimension = { 1, 1 }.