Bug 198199

Summary:

[WHLSL] Make the AST dumper disambiguate expressions using parenthesis to represent AST construction

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

WebGPU

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Saam Barati 2019-05-23 15:49:45 PDT

We would dump "*foo.bar" for "(*foo).bar" which is throughly confusing enough to go maximal parens

Comment 1 Saam Barati 2019-05-23 16:00:13 PDT

Created attachment 370530 [details]
patch

Comment 2 Robin Morisset 2019-05-23 16:02:02 PDT

LGTM

Comment 3 WebKit Commit Bot 2019-05-23 16:42:02 PDT

Comment on attachment 370530 [details]
patch

Clearing flags on attachment: 370530

Committed r245727: <https://trac.webkit.org/changeset/245727>

Comment 4 WebKit Commit Bot 2019-05-23 16:42:04 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-05-23 16:43:32 PDT

<rdar://problem/51088170>