Bug 198199

Summary: [WHLSL] Make the AST dumper disambiguate expressions using parenthesis to represent AST construction
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2019-05-23 15:49:45 PDT
We would dump "*foo.bar" for "(*foo).bar" which is throughly confusing enough to go maximal parens
Attachments
patch (1.74 KB, patch)
2019-05-23 16:00 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-05-23 16:00:13 PDT
Created attachment 370530 [details] patch
Robin Morisset
Comment 2 2019-05-23 16:02:02 PDT
LGTM
WebKit Commit Bot
Comment 3 2019-05-23 16:42:02 PDT
Comment on attachment 370530 [details] patch Clearing flags on attachment: 370530 Committed r245727: <https://trac.webkit.org/changeset/245727>
WebKit Commit Bot
Comment 4 2019-05-23 16:42:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-05-23 16:43:32 PDT
<rdar://problem/51088170>
Note You need to log in before you can comment on or make changes to this bug.