Bug 198193

Summary: [WHLSL] Property resolver needs to recurse to handle the base when simplifying rvalues
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
mmaxfield: review+
patch for landing
none
patch for landing none

Saam Barati
Reported 2019-05-23 13:02:43 PDT
...
Attachments
patch (9.00 KB, patch)
2019-05-23 13:28 PDT, Saam Barati 		mmaxfield: review+
DetailsFormatted DiffDiff
patch for landing (9.65 KB, patch)
2019-05-23 14:38 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (8.98 KB, patch)
2019-05-23 14:40 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-05-23 13:28:53 PDT
Created attachment 370518 [details] patch
Myles C. Maxfield
Comment 2 2019-05-23 14:14:21 PDT
Comment on attachment 370518 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=370518&action=review Cool. > LayoutTests/webgpu/whlsl-nested-dot-expression-rvalue.html:11 > + float shade : attribute(0); I think you should remove the " : attribute(0)"
Saam Barati
Comment 3 2019-05-23 14:38:52 PDT
Created attachment 370520 [details] patch for landing
Saam Barati
Comment 4 2019-05-23 14:40:11 PDT
Created attachment 370521 [details] patch for landing
WebKit Commit Bot
Comment 5 2019-05-23 15:21:10 PDT
Comment on attachment 370521 [details] patch for landing Clearing flags on attachment: 370521 Committed r245721: <https://trac.webkit.org/changeset/245721>
WebKit Commit Bot
Comment 6 2019-05-23 15:21:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-05-23 15:22:22 PDT
<rdar://problem/51084810>
Note You need to log in before you can comment on or make changes to this bug.