Summary: | [iOS] Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is frequently failing or timing out | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||||||
Component: | New Bugs | Assignee: | John Wilander <wilander> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, katherine_cheney, repstein, sroberts, webkit-bot-watchers-bugzilla, webkit-bug-importer, wilander, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=195923 | ||||||||||||
Attachments: |
|
Description
Ryan Haddad
2019-05-23 10:56:37 PDT
Test is timing out or failing almost every run. Skipping test on iOS while waiting for a fix in https://trac.webkit.org/changeset/246318/webkit Created attachment 372161 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 372161 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 372161 [details] Patch for landing Clearing flags on attachment: 372161 Committed r246453: <https://trac.webkit.org/changeset/246453> All reviewed patches have been landed. Closing bug. This test is frequently failing or timing out again on iOS Simulator after it was re-enabled. See: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fwebsite-data-removal-for-site-navigated-to-with-link-decoration.html Re opening bug as test is exhibiting the same flaky failure as before. Created attachment 372368 [details]
Update TestExpectations
Comment on attachment 372368 [details] Update TestExpectations Clearing flags on attachment: 372368 Committed r246562: <https://trac.webkit.org/changeset/246562> Created attachment 381141 [details]
Patch
Comment on attachment 381141 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381141&action=review > LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html:241 > + testRunner.setStatisticsNotifyPagesWhenDataRecordsWereScanned(true); Is this additional call needed? The testRunner.installStatisticsDidScanDataRecordsCallback call above shoud set it to true. Created attachment 381195 [details]
Patch
(In reply to youenn fablet from comment #12) > Comment on attachment 381141 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381141&action=review > > > LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html:241 > > + testRunner.setStatisticsNotifyPagesWhenDataRecordsWereScanned(true); > > Is this additional call needed? > The testRunner.installStatisticsDidScanDataRecordsCallback call above shoud > set it to true. Yes you're right, thanks for pointing that out! The commit-queue encountered the following flaky tests while processing attachment 381195 [details]: inspector/console/webcore-logging.html bug 203118 (authors: drousso@apple.com and eric.carlson@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 381195 [details] Patch Clearing flags on attachment: 381195 Committed r251287: <https://trac.webkit.org/changeset/251287> All reviewed patches have been landed. Closing bug. |