Summary: | [Pointer Events] The mouseover, mouseout, mouseenter, and mouseleave events should not be prevented while the pointer is down | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
Component: | UI Events | Assignee: | Antoine Quint <graouts> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, cdumez, cmarcelo, commit-queue, dbates, dino, esprehn+autocc, ews-watchlist, kangil.han, rniwa, simon.fraser, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=198129 https://bugs.webkit.org/show_bug.cgi?id=198190 |
||||||||||
Attachments: |
|
Description
Antoine Quint
2019-05-23 05:04:33 PDT
Created attachment 370500 [details]
Patch
Comment on attachment 370500 [details] Patch Attachment 370500 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12268566 New failing tests: pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html Created attachment 370503 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 370504 [details]
Patch
Comment on attachment 370504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370504&action=review > LayoutTests/ChangeLog:11 > + * platform/mac-wk1/TestExpectations: Skipping the test on WK1 where the sequence of dispatched mouse events does not match. Is this something that needs to be fixed at some point in the future? Comment on attachment 370504 [details] Patch Clearing flags on attachment: 370504 Committed r245695: <https://trac.webkit.org/changeset/245695> All reviewed patches have been landed. Closing bug. This broke the macOS build (Element.cpp:291:13: error: unused function 'isCompatibilityMouseEvent' [-Werror,-Wunused-function]). Fixed in r245700 (In reply to Alexey Proskuryakov from comment #6) > Comment on attachment 370504 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370504&action=review > > > LayoutTests/ChangeLog:11 > > + * platform/mac-wk1/TestExpectations: Skipping the test on WK1 where the sequence of dispatched mouse events does not match. > > Is this something that needs to be fixed at some point in the future? I'm not sure how important it is to address, but it's worth tracking. Raised https://bugs.webkit.org/show_bug.cgi?id=198190. |