Bug 198165

Summary:

Web Inspector: Overlay: rulers should switch sides if they intersect the highlighted node(s) so they don't obstruct any content

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Devin Rousso

Reported 2019-05-22 22:32:39 PDT

If the node being highlighted is against the top edge of the screen, the top ruler should shift to the bottom. If the node being highlighted is against the left edge of the screen, the left ruler should shift to the right.

Attachments
Patch (17.26 KB, patch) 2019-05-23 01:20 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-05-23 01:20:33 PDT

Created attachment 370495 [details] Patch

Devin Rousso

Comment 2 2019-05-23 01:20:45 PDT

I tested this using <https://devinrousso.com/demo/WebKit/bounds.html> :)

WebKit Commit Bot

Comment 3 2019-05-23 17:10:15 PDT

Comment on attachment 370495 [details] Patch Clearing flags on attachment: 370495 Committed r245728: <https://trac.webkit.org/changeset/245728>

WebKit Commit Bot

Comment 4 2019-05-23 17:10:17 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-05-23 17:11:21 PDT

<rdar://problem/51089099>

Note You need to log in before you can comment on or make changes to this bug.