Bug 198150

Summary: release builds of webkit cannot be used to generate a dyld shared cache
Product: WebKit Reporter: Stephanie Lewis <slewis>
Component: Tools / TestsAssignee: Stephanie Lewis <slewis>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, mitz, slewis
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch mitz: review+

Stephanie Lewis
Reported 2019-05-22 17:18:55 PDT
https://bugs.webkit.org/show_bug.cgi?id=170385 fixed a warning about Mac OS build sleight of hand for libwebrtc by telling the linker that release builds of WebKit and WebCore will not be placed in a dyld shared cache. However on some devices this is desirable. Since we only do the sleight of hand on macosx restrict the flag to macosx.
Attachments
patch (4.25 KB, patch)
2019-05-22 17:26 PDT, Stephanie Lewis 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephanie Lewis
Comment 1 2019-05-22 17:21:36 PDT
<rdar://problem/50675982>
Stephanie Lewis
Comment 2 2019-05-22 17:26:25 PDT
Created attachment 370471 [details] patch
Stephanie Lewis
Comment 3 2019-05-23 14:22:18 PDT
Thanks Dan. http://trac.webkit.org/projects/webkit/changeset/245717
Note You need to log in before you can comment on or make changes to this bug.