Bug 198143
| Summary: | [WHLSL] Detection of duplicate functions does not correctly deal with auto-generated setters and getters | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Robin Morisset <rmorisset> |
| Component: | WebGPU | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | mmaxfield |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=195925 | ||
Robin Morisset
According to the spec, it is invalid to define an ander and a setter for the same field of the same type, as the ander leads to the creation of a setter, that will conflict with the user-defined one.
Because the implementation currently does not generate setters in this manner, but instead writes their code inline whenever it is needed (https://bugs.webkit.org/show_bug.cgi?id=195925), we won't correctly reject such programs if the ander/setter is never used.
The same problem exists for ander/getter.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Myles C. Maxfield
I believe it is no longer possible for a user to define both an ander and a setter for the same field.
Myles C. Maxfield
(In reply to Myles C. Maxfield from comment #1)
> I believe it is no longer possible for a user to define both an ander and a
> setter for the same field.
Whoops, disregard this comment, I misread the bug.
Myles C. Maxfield
WHLSL is no longer relevant.