Bug 198135

Summary:

[iOS] The shouldIgnoreMetaViewport test option incorrectly persists across layout tests

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

Tools / Tests

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bdakin, commit-queue, ews-watchlist, sroberts, thorton, webkit-bug-importer, yongjun_zhang

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews210 for win-future	none
For EWS	none

Wenson Hsieh

Reported 2019-05-22 12:28:01 PDT

<rdar://problem/51001306>

Attachments
Patch (7.08 KB, patch) 2019-05-22 12:48 PDT, Wenson Hsieh	ap: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews210 for win-future (13.46 MB, application/zip) 2019-05-22 15:10 PDT, EWS Watchlist	no flags	Details
For EWS (7.09 KB, patch) 2019-05-22 16:06 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2019-05-22 12:48:09 PDT Comment hidden (obsolete)

Created attachment 370433 [details] Patch

Wenson Hsieh

Comment 2 2019-05-22 15:08:34 PDT

Thanks for the review! > fast/visual-viewport/rtl-nonzoomed-rects.html [ Failure ] > fast/visual-viewport/rtl-zoomed-rects.html [ Failure ] > fast/visual-viewport/rubberbanding-viewport-rects-extended-background.html [ Failure ] > fast/visual-viewport/rubberbanding-viewport-rects-header-footer.html [ Failure ] > fast/visual-viewport/rubberbanding-viewport-rects.html [ Failure ] > fast/visual-viewport/viewport-dimensions.html [ Failure ] > fast/visual-viewport/zoomed-fixed-header-and-footer.html [ Failure ] > fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html [ Failure ] > fast/visual-viewport/zoomed-fixed.html [ Failure ] > fast/visual-viewport/zoomed-rects.html [ Failure ] ...so these started failing after I _fixed_ the timeouts in the other viewport tests :( It seems these tests currently rely on the viewport tests timing out. I'll look into these test failures and find a way to fix them.

EWS Watchlist

Comment 3 2019-05-22 15:10:52 PDT Comment hidden (obsolete)

Comment on attachment 370433 [details] Patch Attachment 370433 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12261482 New failing tests: js/dom/custom-constructors.html

EWS Watchlist

Comment 4 2019-05-22 15:10:54 PDT Comment hidden (obsolete)

Created attachment 370450 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Wenson Hsieh

Comment 5 2019-05-22 16:04:03 PDT

(In reply to Wenson Hsieh from comment #2) > Thanks for the review! > > > fast/visual-viewport/rtl-nonzoomed-rects.html [ Failure ] > > fast/visual-viewport/rtl-zoomed-rects.html [ Failure ] > > fast/visual-viewport/rubberbanding-viewport-rects-extended-background.html [ Failure ] > > fast/visual-viewport/rubberbanding-viewport-rects-header-footer.html [ Failure ] > > fast/visual-viewport/rubberbanding-viewport-rects.html [ Failure ] > > fast/visual-viewport/viewport-dimensions.html [ Failure ] > > fast/visual-viewport/zoomed-fixed-header-and-footer.html [ Failure ] > > fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html [ Failure ] > > fast/visual-viewport/zoomed-fixed.html [ Failure ] > > fast/visual-viewport/zoomed-rects.html [ Failure ] > > ...so these started failing after I _fixed_ the timeouts in the other > viewport tests :( > > It seems these tests currently rely on the viewport tests timing out. I'll > look into these test failures and find a way to fix them. Actually, I'm able to reproduce these failures locally, even without my patch 🤔. I don't quite grok what's going on, but I have a feeling this may be a manifestation of <rdar://problem/50501718>. I'll re-upload my patch to run against EWS again, and see how it fares.

Wenson Hsieh

Comment 6 2019-05-22 16:06:17 PDT

Created attachment 370459 [details] For EWS

WebKit Commit Bot

Comment 7 2019-05-22 17:41:53 PDT

Comment on attachment 370459 [details] For EWS Clearing flags on attachment: 370459 Committed r245663: <https://trac.webkit.org/changeset/245663>

WebKit Commit Bot

Comment 8 2019-05-22 17:41:55 PDT

All reviewed patches have been landed. Closing bug.

Wenson Hsieh

Comment 9 2019-05-22 20:24:59 PDT

*** Bug 198085 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.