Bug 198125

Summary: [WPE] Build fails with ENABLE_VIDEO=OFF and ENABLE_WEB_AUDIO=OFF
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, commit-queue, pnormand, pvollan, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 none

Adrian Perez
Reported 2019-05-22 09:25:32 PDT
Probably this affects the GTK port as well. Build error follows: --- In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-17.cpp:2: ../Source/WebKit/WebProcess/glib/WebProcessGLib.cpp:31:10: fatal error: WebCore/GStreamerCommon.h: No such file or directory #include <WebCore/GStreamerCommon.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Attachments
Patch (1.23 KB, patch)
2019-05-22 09:45 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch v2 (1.88 KB, patch)
2019-05-22 10:24 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2019-05-22 09:45:36 PDT
Created attachment 370406 [details] Patch
Adrian Perez
Comment 2 2019-05-22 09:48:28 PDT
Comment on attachment 370406 [details] Patch I'll have to update this patch, there is another error after fixing the first one: ../Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:34:10: fatal error: WebCore/GStreamerCommon.h: No such file or directory #include <WebCore/GStreamerCommon.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Adrian Perez
Comment 3 2019-05-22 10:24:57 PDT
Created attachment 370416 [details] Patch v2
Philippe Normand
Comment 4 2019-05-23 00:13:49 PDT
Comment on attachment 370416 [details] Patch v2 👍
WebKit Commit Bot
Comment 5 2019-05-23 00:28:30 PDT
Comment on attachment 370416 [details] Patch v2 Clearing flags on attachment: 370416 Committed r245676: <https://trac.webkit.org/changeset/245676>
WebKit Commit Bot
Comment 6 2019-05-23 00:28:32 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-05-23 00:29:19 PDT
<rdar://problem/51058526>
Note You need to log in before you can comment on or make changes to this bug.