| Summary: | [Apple] Enable variation fonts on all Apple platforms | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dino, ews-watchlist, jonlee, keith_miller, mark.lam, mmaxfield, msaboff, saam, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2019-05-21 19:06:09 PDT
Created attachment 370371 [details]
Patch
Attachment 370371 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Still relevant? Comment on attachment 370371 [details] Patch Rejecting attachment 370371 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 370371, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=370371&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=198100&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 370371 from bug 198100. Fetching: https://bugs.webkit.org/attachment.cgi?id=370371 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 12 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/PAL/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 380. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig.rej patching file Source/WebCore/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 380. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/Configurations/FeatureDefines.xcconfig.rej patching file Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 380. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig.rej patching file Source/WebKit/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 380. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Configurations/FeatureDefines.xcconfig.rej patching file Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 380. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 380. 1 out of 1 hunk FAILED -- saving rejects to file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13259356 Created attachment 383668 [details]
Patch for committing
Comment on attachment 383668 [details] Patch for committing Clearing flags on attachment: 383668 Committed r252516: <https://trac.webkit.org/changeset/252516> |