Bug 198068

Summary:

[WebAuthN] Make WebAuthN default on only on macOS

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebKit Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex.gaynor, bfulgham, commit-queue, ews-watchlist, jiewen_tan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

181943

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews215 for win-future	none

Jiewen Tan

Reported 2019-05-20 20:43:35 PDT

Make WebAuthN default on only on macOS.

Attachments
Patch (1.84 KB, patch) 2019-05-20 20:52 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews215 for win-future (13.63 MB, application/zip) 2019-05-21 03:24 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-05-20 20:44:31 PDT

<rdar://problem/50971874>

Radar WebKit Bug Importer

Comment 2 2019-05-20 20:44:33 PDT Comment hidden (obsolete)

<rdar://problem/50971875>

Jiewen Tan

Comment 3 2019-05-20 20:52:34 PDT

Created attachment 370298 [details] Patch

EWS Watchlist

Comment 4 2019-05-21 03:24:13 PDT Comment hidden (obsolete)

Comment on attachment 370298 [details] Patch Attachment 370298 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12244932 New failing tests: fast/block/float/float-with-anonymous-previous-sibling.html

EWS Watchlist

Comment 5 2019-05-21 03:24:14 PDT Comment hidden (obsolete)

Created attachment 370309 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Brent Fulgham

Comment 6 2019-05-21 07:58:56 PDT

Comment on attachment 370298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370298&action=review > Source/WebKit/Shared/WebPreferencesDefaultValues.h:276 > +#if PLATFORM(MAC) Do any other ports support iOS?

Jiewen Tan

Comment 7 2019-05-21 11:33:38 PDT

WebAuthN is disabled by a compile time flag in Win ports, and therefore I don't believe those test failures are related.

Jiewen Tan

Comment 8 2019-05-21 11:36:34 PDT

(In reply to Brent Fulgham from comment #6) > Comment on attachment 370298 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370298&action=review > > > Source/WebKit/Shared/WebPreferencesDefaultValues.h:276 > > +#if PLATFORM(MAC) > > Do any other ports support iOS? I don't think so. The compile time flag is on only for macOS and iOS, and therefore other ports are off by default. Thanks Brent for r+ this patch.

WebKit Commit Bot

Comment 9 2019-05-21 12:04:03 PDT

Comment on attachment 370298 [details] Patch Clearing flags on attachment: 370298 Committed r245589: <https://trac.webkit.org/changeset/245589>

WebKit Commit Bot

Comment 10 2019-05-21 12:04:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.