| Summary: | [WebAuthN] Make WebAuthN default on only on macOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
| Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | alex.gaynor, bfulgham, commit-queue, ews-watchlist, jiewen_tan, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 181943 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jiewen Tan
2019-05-20 20:43:35 PDT
Created attachment 370298 [details]
Patch
Comment on attachment 370298 [details] Patch Attachment 370298 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12244932 New failing tests: fast/block/float/float-with-anonymous-previous-sibling.html Created attachment 370309 [details]
Archive of layout-test-results from ews215 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 370298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370298&action=review > Source/WebKit/Shared/WebPreferencesDefaultValues.h:276 > +#if PLATFORM(MAC) Do any other ports support iOS? WebAuthN is disabled by a compile time flag in Win ports, and therefore I don't believe those test failures are related. (In reply to Brent Fulgham from comment #6) > Comment on attachment 370298 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370298&action=review > > > Source/WebKit/Shared/WebPreferencesDefaultValues.h:276 > > +#if PLATFORM(MAC) > > Do any other ports support iOS? I don't think so. The compile time flag is on only for macOS and iOS, and therefore other ports are off by default. Thanks Brent for r+ this patch. Comment on attachment 370298 [details] Patch Clearing flags on attachment: 370298 Committed r245589: <https://trac.webkit.org/changeset/245589> All reviewed patches have been landed. Closing bug. |