Bug 198056

Summary: [WinCairo] Build WebDriver
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebDriverAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cgarcia, commit-queue, ews-watchlist, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2019-05-20 15:42:10 PDT
Stub out implementations so WebDriver will build.
Attachments
Patch (60.39 KB, patch)
2019-05-20 16:16 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-05-20 16:16:33 PDT
Created attachment 370278 [details] Patch
EWS Watchlist
Comment 2 2019-05-20 16:18:42 PDT
Attachment 370278 [details] did not pass style-queue: ERROR: Source/WebDriver/socket/SessionHostSocket.cpp:35: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/socket/SessionHostSocket.cpp:44: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2019-05-21 06:10:58 PDT
Comment on attachment 370278 [details] Patch Clearing flags on attachment: 370278 Committed r245567: <https://trac.webkit.org/changeset/245567>
WebKit Commit Bot
Comment 4 2019-05-21 06:11:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-05-21 06:11:21 PDT
<rdar://problem/50982770>
Note You need to log in before you can comment on or make changes to this bug.