Bug 198056 - [WinCairo] Build WebDriver
Summary: [WinCairo] Build WebDriver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-20 15:42 PDT by Don Olmstead
Modified: 2019-05-21 06:11 PDT (History)
6 users (show)

See Also:

Attachments
Patch (60.39 KB, patch)
2019-05-20 16:16 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-05-20 15:42:10 PDT 
Stub out implementations so WebDriver will build.
Comment 1 Don Olmstead 2019-05-20 16:16:33 PDT 
Created attachment 370278 [details]
Patch
Comment 2 EWS Watchlist 2019-05-20 16:18:42 PDT 
Attachment 370278 [details] did not pass style-queue:


ERROR: Source/WebDriver/socket/SessionHostSocket.cpp:35:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/socket/SessionHostSocket.cpp:44:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2019-05-21 06:10:58 PDT 
Comment on attachment 370278 [details]
Patch

Clearing flags on attachment: 370278

Committed r245567: <https://trac.webkit.org/changeset/245567>
Comment 4 WebKit Commit Bot 2019-05-21 06:11:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-05-21 06:11:21 PDT 
<rdar://problem/50982770>