Bug 198031

Summary: Add a mach-lookup for 'AGXCompilerService'
Product: WebKit Reporter: Zhifei Fang <zhifei_fang>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, commit-queue, dino, ews-feeder, mjs, pvollan, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zhifei Fang
Reported 2019-05-19 23:11:08 PDT
<rdar://problem/50552974>
Attachments
Patch (1.54 KB, patch)
2019-05-19 23:20 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhifei Fang
Comment 1 2019-05-19 23:20:42 PDT
Created attachment 370240 [details] Patch
Maciej Stachowiak
Comment 2 2019-05-20 02:03:13 PDT
Looks good to me but perhaps Brent or Per Arne should look at it as well.
Per Arne Vollan
Comment 3 2019-05-20 07:12:00 PDT
Comment on attachment 370240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370240&action=review R=me. > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-402 > (deny mach-lookup > - (global-name "com.apple.AGXCompilerService") Do you need to explicitly allow it, or is it enough to remove it from the deny list?
EWS
Comment 4 2019-05-20 10:34:56 PDT
Comment on attachment 370240 [details] Patch Rejecting attachment 370240 [details] from commit-queue. zhifei_fang@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 5 2019-05-20 10:41:21 PDT
Comment on attachment 370240 [details] Patch Clearing flags on attachment: 370240 Committed r245520: <https://trac.webkit.org/changeset/245520>
WebKit Commit Bot
Comment 6 2019-05-20 10:41:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-05-20 10:43:01 PDT
<rdar://problem/50951531>
Note You need to log in before you can comment on or make changes to this bug.