| Summary: | Web Inspector: Storage tab crashes easily when adding new local/session storage entries. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | 198003 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 370268 [details]
Patch
Comment on attachment 370268 [details]
Patch
Woohoo! r=me
Comment on attachment 370268 [details] Patch Clearing flags on attachment: 370268 Committed r245535: <https://trac.webkit.org/changeset/245535> All reviewed patches have been landed. Closing bug. |
(Evidently somebody noticed this a year ago on our end but it never got reported upstream... :sad_panda:) Steps: 1. Open Storage tab 2. Double-click an empty row 3. Enter text for key 4. Press tab 5. Enter text for value 6. Press tab Result: > TypeError: undefined is not an object (evaluating 'this._editingNode._element.children') (at DataGrid.js:523:49) > _startEditingNodeAtColumnIndex @ DataGrid.js:523:49 > moveToNextCell @ DataGrid.js:596:52 > _editingCommitted @ DataGrid.js:606:28 > _editingCommitted @ [native code] > editingCommitted @ EditingSupport.js:197:26 > blurEventListener @ EditingSupport.js:143:30 Notes: - After step 4, the text for the key disappears. - If you press enter instead of tab in step 6, the crash does not occur and the text for the key re-appears, but now the text for the value disappears.