Summary: | [ews-build] Add clickable url in UI for uploaded S3 archive | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, ews-watchlist, jbedard, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Aakash Jain
2019-05-17 13:27:39 PDT
Created attachment 370148 [details]
Patch
Attachment 370148 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:793: [TransferToS3.start] Use of super on an old style class [pylint/E1002] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 370148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370148&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:800 > + match = re.search(r'S3 URL: (?P<url>[^\s]+)', log_text) Can we have a comment here with an example of the line we're mapping? Created attachment 370153 [details]
Patch
> Can we have a comment here with an example of the line we're mapping?
Added
Attachment 370153 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:793: [TransferToS3.start] Use of super on an old style class [pylint/E1002] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 370153 [details] Patch Clearing flags on attachment: 370153 Committed r245489: <https://trac.webkit.org/changeset/245489> All reviewed patches have been landed. Closing bug. |