Bug 197995

Summary: Avoid races in taking networking assertions for downloads by having both Networking and UIProcess do it
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Brady Eidson
Reported 2019-05-17 13:08:51 PDT
Avoid races in taking networking assertions for downloads by having both Networking and UIProcess do it <rdar://problem/50564630>
Attachments
Patch (8.11 KB, patch)
2019-05-17 13:12 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (8.05 KB, patch)
2019-05-17 13:26 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (8.09 KB, patch)
2019-05-17 13:50 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2019-05-17 13:12:31 PDT
Created attachment 370138 [details] Patch
Brady Eidson
Comment 2 2019-05-17 13:26:01 PDT
Created attachment 370140 [details] Patch
Chris Dumez
Comment 3 2019-05-17 13:40:09 PDT
Comment on attachment 370140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370140&action=review > Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:64 > + RELEASE_LOG(Loading, "Took 'WebKit downloads' assertion in NetworkProcess"); We normally use ProcessSuspension channel for such logging. > Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:78 > + RELEASE_LOG(Loading, "Dropped 'WebKit downloads' assertion in NetworkProcess"); We normally use ProcessSuspension channel for such logging. > Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:97 > + RELEASE_LOG(Loading, "UIProcess took 'WebKit downloads' assertions for UIProcess and NetworkProcess"); We normally use ProcessSuspension channel for such logging. > Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:125 > + RELEASE_LOG(Loading, "UIProcess released 'WebKit downloads' assertions for UIProcess and NetworkProcess"); We normally use ProcessSuspension channel for such logging. > Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:141 > + RELEASE_LOG(Loading, "UIProcess DownloadProxyMap invalidated - Released 'WebKit downloads' assertions for UIProcess and NetworkProcess"); We normally use ProcessSuspension channel for such logging.
Brady Eidson
Comment 4 2019-05-17 13:50:13 PDT
Created attachment 370146 [details] Patch
WebKit Commit Bot
Comment 5 2019-05-17 14:37:13 PDT
Comment on attachment 370146 [details] Patch Clearing flags on attachment: 370146 Committed r245480: <https://trac.webkit.org/changeset/245480>
WebKit Commit Bot
Comment 6 2019-05-17 14:37:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.