Bug 19798

Summary:

REGRESSION: Masks have several problems in trunk

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

SVG

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, hyatt, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

19799

Attachments:

Description	Flags
Initial patch	hyatt: review+

Description Nikolas Zimmermann 2008-06-28 03:32:18 PDT

All problems covered by existing LayoutTests. Unfortunately, when pixel tests aren't looked at, there is no way anyone could notice :(

svg/W3C-SVG-1.1/masking-mask-01-b.svg - masks seem translated
svg/custom/mask-inside-defs.svg - broken
svg/custom/visibility-override-mask.svg - broken

Comment 1 Nikolas Zimmermann 2008-08-11 21:24:41 PDT

Found the culprit: http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm

Uploading fix soon.

Comment 2 Nikolas Zimmermann 2008-08-12 03:41:51 PDT

Created attachment 22744 [details]
Initial patch

Would be nice if David could have a look, as one of his refactorings broke SVG <mask> support.

Comment 3 Dave Hyatt 2008-08-12 13:57:48 PDT

Comment on attachment 22744 [details]
Initial patch

r=me

Comment 4 Nikolas Zimmermann 2008-08-12 14:11:47 PDT

Landed in r35694.