Bug 197967

Summary: Storage Access API: Call completion handlers in NetworkConnectionToWebProcess::hasStorageAccess() and NetworkConnectionToWebProcess::requestStorageAccess() when feature is off
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

John Wilander
Reported 2019-05-16 15:37:06 PDT
NetworkConnectionToWebProcess::hasStorageAccess() and NetworkConnectionToWebProcess::requestStorageAccess() should call their completion handlers when there is no Resource Load Statistics object, i.e. when Resource Load Statistics is off.
Attachments
Patch (6.41 KB, patch)
2019-05-16 15:48 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Wilander
Comment 1 2019-05-16 15:37:18 PDT
<rdar://problem/50753129>
John Wilander
Comment 2 2019-05-16 15:48:23 PDT
Created attachment 370080 [details] Patch
Brent Fulgham
Comment 3 2019-05-16 15:59:16 PDT
Comment on attachment 370080 [details] Patch Good catch. r=me
John Wilander
Comment 4 2019-05-16 16:08:55 PDT
Thank you, Brent! I'll wait for EWS feedback before landing.
WebKit Commit Bot
Comment 5 2019-05-16 16:33:46 PDT
Comment on attachment 370080 [details] Patch Clearing flags on attachment: 370080 Committed r245427: <https://trac.webkit.org/changeset/245427>
WebKit Commit Bot
Comment 6 2019-05-16 16:33:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.