Bug 197967

Summary: Storage Access API: Call completion handlers in NetworkConnectionToWebProcess::hasStorageAccess() and NetworkConnectionToWebProcess::requestStorageAccess() when feature is off
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description John Wilander 2019-05-16 15:37:06 PDT
NetworkConnectionToWebProcess::hasStorageAccess() and NetworkConnectionToWebProcess::requestStorageAccess() should call their completion handlers when there is no Resource Load Statistics object, i.e. when Resource Load Statistics is off.
Comment 1 John Wilander 2019-05-16 15:37:18 PDT
Comment 2 John Wilander 2019-05-16 15:48:23 PDT
Created attachment 370080 [details]
Comment 3 Brent Fulgham 2019-05-16 15:59:16 PDT
Comment on attachment 370080 [details]

Good catch. r=me
Comment 4 John Wilander 2019-05-16 16:08:55 PDT
Thank you, Brent! I'll wait for EWS feedback before landing.
Comment 5 WebKit Commit Bot 2019-05-16 16:33:46 PDT
Comment on attachment 370080 [details]

Clearing flags on attachment: 370080

Committed r245427: <https://trac.webkit.org/changeset/245427>
Comment 6 WebKit Commit Bot 2019-05-16 16:33:48 PDT
All reviewed patches have been landed.  Closing bug.