Bug 197967 - Storage Access API: Call completion handlers in NetworkConnectionToWebProcess::hasStorageAccess() and NetworkConnectionToWebProcess::requestStorageAccess() when feature is off
Summary: Storage Access API: Call completion handlers in NetworkConnectionToWebProcess...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-16 15:37 PDT by John Wilander
Modified: 2019-05-16 16:33 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.41 KB, patch)
2019-05-16 15:48 PDT, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2019-05-16 15:37:06 PDT
NetworkConnectionToWebProcess::hasStorageAccess() and NetworkConnectionToWebProcess::requestStorageAccess() should call their completion handlers when there is no Resource Load Statistics object, i.e. when Resource Load Statistics is off.
Comment 1 John Wilander 2019-05-16 15:37:18 PDT
<rdar://problem/50753129>
Comment 2 John Wilander 2019-05-16 15:48:23 PDT
Created attachment 370080 [details]
Patch
Comment 3 Brent Fulgham 2019-05-16 15:59:16 PDT
Comment on attachment 370080 [details]
Patch

Good catch. r=me
Comment 4 John Wilander 2019-05-16 16:08:55 PDT
Thank you, Brent! I'll wait for EWS feedback before landing.
Comment 5 WebKit Commit Bot 2019-05-16 16:33:46 PDT
Comment on attachment 370080 [details]
Patch

Clearing flags on attachment: 370080

Committed r245427: <https://trac.webkit.org/changeset/245427>
Comment 6 WebKit Commit Bot 2019-05-16 16:33:48 PDT
All reviewed patches have been landed.  Closing bug.