| Summary: | Allow sequential playback of media files when initial playback started with a user gesture | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||||
| Status: | ASSIGNED --- | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, rniwa, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | Other | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Eric Carlson
2019-05-16 13:20:24 PDT
Created attachment 370061 [details]
Patch
Comment on attachment 370061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370061&action=review > Source/WebCore/html/HTMLMediaElement.cpp:5921 > + document().mediaFinishedPlaying(); Maybe we should have a better name for mediaFinishedPlaying, since it is not called for every media but only 'unrestricted' media. Comment on attachment 370061 [details] Patch Attachment 370061 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12209476 New failing tests: media/media-fullscreen-inline.html Created attachment 370072 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 370061 [details] Patch Attachment 370061 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12209555 New failing tests: media/media-fullscreen-inline.html Created attachment 370074 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 370061 [details] Patch Attachment 370061 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12209593 New failing tests: media/media-fullscreen-inline.html Created attachment 370075 [details]
Archive of layout-test-results from ews113 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 370061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370061&action=review >> Source/WebCore/html/HTMLMediaElement.cpp:5921 >> + document().mediaFinishedPlaying(); > > Maybe we should have a better name for mediaFinishedPlaying, since it is not called for every media but only 'unrestricted' media. Good point, I'll change the name to userActivatedMediaFinishedPlaying. Created attachment 370114 [details]
Patch
Comment on attachment 370114 [details] Patch Clearing flags on attachment: 370114 Committed r245467: <https://trac.webkit.org/changeset/245467> |