Bug 197943

Summary: Add a website policy to disable the legacy -webkit-overflow-scrolling:touch behavior
Product: WebKit Reporter: Antoine Quint <graouts>
Component: ScrollingAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch
none
Patch bfulgham: review+

Antoine Quint
Reported 2019-05-16 02:25:46 PDT
Add a website policy to disable the legacy -webkit-overflow-scrolling:touch behavior
Attachments
Patch (18.45 KB, patch)
2019-05-16 02:30 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (25.64 KB, patch)
2019-05-17 01:32 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (8.06 MB, application/zip)
2019-05-17 03:31 PDT, EWS Watchlist 		no flags
Details
Patch (26.67 KB, patch)
2019-05-17 12:15 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (26.58 KB, patch)
2019-05-17 12:23 PDT, Antoine Quint 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2019-05-16 02:26:12 PDT
<rdar://problem/49078202>
Antoine Quint
Comment 2 2019-05-16 02:30:48 PDT
Created attachment 370033 [details] Patch
Antoine Quint
Comment 3 2019-05-16 10:29:17 PDT
Wenson says this can be tested with <!-- webkit-test-runner [ shouldUseModernCompatibilityMode=true ] -->.
Antoine Quint
Comment 4 2019-05-16 10:29:48 PDT
Simon, do you know which tests should be duplicated to also test them with the legacy mode disabled?
Simon Fraser (smfr)
Comment 5 2019-05-16 11:06:51 PDT
I think you want variants of: platform/ios/ios/fast/css/webkit-overflow-scrolling-parsing.html fast/scrolling/ios/overflow-scrolling-touch-enabled-stacking.html
Antoine Quint
Comment 6 2019-05-17 01:32:42 PDT
Created attachment 370110 [details] Patch
EWS Watchlist
Comment 7 2019-05-17 03:31:48 PDT
Comment on attachment 370110 [details] Patch Attachment 370110 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12213804 New failing tests: platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html fast/scrolling/ipad/overflow-scrolling-touch-enabled-stacking-modern-compatibility-mode.html
EWS Watchlist
Comment 8 2019-05-17 03:31:50 PDT
Created attachment 370113 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Brent Fulgham
Comment 9 2019-05-17 09:44:03 PDT
Comment on attachment 370110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370110&action=review > Source/WebCore/ChangeLog:10 > + platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html These tests don't seem to work on iOS-simulator, which is the only place we run iOS tests (atm). That makes it seem like this patch doesn't work. Or do our build.webkit.org tests only run without "#if ENABLE(OVERFLOW_SCROLLING_TOUCH)" disabled?
Wenson Hsieh
Comment 10 2019-05-17 09:50:43 PDT
Comment on attachment 370110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370110&action=review >> Source/WebCore/ChangeLog:10 >> + platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html > > These tests don't seem to work on iOS-simulator, which is the only place we run iOS tests (atm). That makes it seem like this patch doesn't work. > > Or do our build.webkit.org tests only run without "#if ENABLE(OVERFLOW_SCROLLING_TOUCH)" disabled? The implementation of "modern compatibility mode" is tucked away in WebKitAdditions. It's not expected that these tests will work with just open source code.
Antoine Quint
Comment 11 2019-05-17 12:15:09 PDT
Created attachment 370132 [details] Patch
Antoine Quint
Comment 12 2019-05-17 12:23:28 PDT
Created attachment 370133 [details] Patch
Brent Fulgham
Comment 13 2019-05-17 12:30:21 PDT
Comment on attachment 370133 [details] Patch r=mews
Antoine Quint
Comment 14 2019-05-17 15:05:17 PDT
Committed r245483: <https://trac.webkit.org/changeset/245483>
Note You need to log in before you can comment on or make changes to this bug.