Summary: | Horizontal scrollbar flashes after scrolling vertically with keyboard | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, dino, ews-watchlist | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Tim Horton
2019-05-16 01:17:36 PDT
Created attachment 370029 [details]
Patch
Comment on attachment 370029 [details] Patch Attachment 370029 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12205879 New failing tests: fast/shadow-dom/svg-text-path-href-change-in-shadow-tree.html js/dom/try-catch-crash.html svg/text/textpath-reference-update.html fast/shadow-dom/svg-use-href-change-in-shadow-tree.html js/dom/custom-constructors.html Created attachment 370038 [details]
Archive of layout-test-results from ews211 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 370098 [details]
Patch
iOS Build failure: WKKeyboardScrollingAnimator.mm:592:15: error: unused function 'axesForDelta' [-Werror,-Wunused-function] Comment on attachment 370098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370098&action=review > Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:-592 > -- (void)scrollToContentOffset:(WebCore::FloatPoint)contentOffsetDelta animated:(BOOL)animated #if HAVE(UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI) ? Created attachment 370800 [details]
Patch
Comment on attachment 370800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370800&action=review > Source/WebKit/Platform/spi/ios/UIKitSPI.h:354 > +- (void)_flashScrollIndicatorsForAxes:(UIAxis)axes persistingPreviousFlashes:(BOOL)persisting; Wow. https://www.quora.com/What-is-the-plural-form-of-axis-1 Comment on attachment 370800 [details] Patch Clearing flags on attachment: 370800 Committed r245832: <https://trac.webkit.org/changeset/245832> All reviewed patches have been landed. Closing bug. |