Bug 197935

Summary: AX: screenHasInvertedColors should use AppKit method, not CG
Product: WebKit Reporter: Greg Hughes <ghughes>
Component: AccessibilityAssignee: Greg Hughes <ghughes>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Greg Hughes
Reported 2019-05-15 17:32:23 PDT
screenHasInvertedColors should use [[NSWorkspace sharedWorkspace] accessibilityDisplayShouldInvertColors], not CGDisplayUsesInvertedPolarity
Attachments
Patch (2.52 KB, patch)
2019-05-15 17:47 PDT, Greg Hughes 		no flags
DetailsFormatted DiffDiff
Patch (2.35 KB, patch)
2019-05-15 17:57 PDT, Greg Hughes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-15 17:32:36 PDT
<rdar://problem/50834405>
Greg Hughes
Comment 2 2019-05-15 17:47:11 PDT
Created attachment 370012 [details] Patch
chris fleizach
Comment 3 2019-05-15 17:49:32 PDT
Comment on attachment 370012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370012&action=review > Source/WebCore/platform/mac/PlatformScreenMac.mm:264 > +#if HAVE_ACCESSIBILITY_SUPPORT can you put this in a single method that can be called be both locations?
Greg Hughes
Comment 4 2019-05-15 17:57:49 PDT
Created attachment 370013 [details] Patch
WebKit Commit Bot
Comment 5 2019-05-16 02:22:27 PDT
Comment on attachment 370013 [details] Patch Clearing flags on attachment: 370013 Committed r245392: <https://trac.webkit.org/changeset/245392>
WebKit Commit Bot
Comment 6 2019-05-16 02:22:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.