Bug 197935

Summary: AX: screenHasInvertedColors should use AppKit method, not CG
Product: WebKit Reporter: Greg Hughes <ghughes>
Component: AccessibilityAssignee: Greg Hughes <ghughes>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Greg Hughes 2019-05-15 17:32:23 PDT
screenHasInvertedColors should use [[NSWorkspace sharedWorkspace] accessibilityDisplayShouldInvertColors], not CGDisplayUsesInvertedPolarity
Comment 1 Radar WebKit Bug Importer 2019-05-15 17:32:36 PDT
<rdar://problem/50834405>
Comment 2 Greg Hughes 2019-05-15 17:47:11 PDT
Created attachment 370012 [details]
Patch
Comment 3 chris fleizach 2019-05-15 17:49:32 PDT
Comment on attachment 370012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370012&action=review

> Source/WebCore/platform/mac/PlatformScreenMac.mm:264
> +#if HAVE_ACCESSIBILITY_SUPPORT

can you put this in a single method that can be called be both locations?
Comment 4 Greg Hughes 2019-05-15 17:57:49 PDT
Created attachment 370013 [details]
Patch
Comment 5 WebKit Commit Bot 2019-05-16 02:22:27 PDT
Comment on attachment 370013 [details]
Patch

Clearing flags on attachment: 370013

Committed r245392: <https://trac.webkit.org/changeset/245392>
Comment 6 WebKit Commit Bot 2019-05-16 02:22:29 PDT
All reviewed patches have been landed.  Closing bug.