Bug 197935 - AX: screenHasInvertedColors should use AppKit method, not CG
Summary: AX: screenHasInvertedColors should use AppKit method, not CG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Greg Hughes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-15 17:32 PDT by Greg Hughes
Modified: 2019-05-16 02:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.52 KB, patch)
2019-05-15 17:47 PDT, Greg Hughes 		no flags Details | Formatted Diff | Diff
Patch (2.35 KB, patch)
2019-05-15 17:57 PDT, Greg Hughes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Hughes 2019-05-15 17:32:23 PDT 
screenHasInvertedColors should use [[NSWorkspace sharedWorkspace] accessibilityDisplayShouldInvertColors], not CGDisplayUsesInvertedPolarity
Comment 1 Radar WebKit Bug Importer 2019-05-15 17:32:36 PDT 
<rdar://problem/50834405>
Comment 2 Greg Hughes 2019-05-15 17:47:11 PDT 
Created attachment 370012 [details]
Patch
Comment 3 chris fleizach 2019-05-15 17:49:32 PDT 
Comment on attachment 370012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370012&action=review

> Source/WebCore/platform/mac/PlatformScreenMac.mm:264
> +#if HAVE_ACCESSIBILITY_SUPPORT

can you put this in a single method that can be called be both locations?
Comment 4 Greg Hughes 2019-05-15 17:57:49 PDT 
Created attachment 370013 [details]
Patch
Comment 5 WebKit Commit Bot 2019-05-16 02:22:27 PDT 
Comment on attachment 370013 [details]
Patch

Clearing flags on attachment: 370013

Committed r245392: <https://trac.webkit.org/changeset/245392>
Comment 6 WebKit Commit Bot 2019-05-16 02:22:29 PDT 
All reviewed patches have been landed.  Closing bug.