Bug 197897

Summary: Fix flakey test fast/events/autoscroll-when-input-is-offscreen.html
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, ews-watchlist, rniwa, sroberts, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews100 for mac-highsierra
none
Patch none

Description Megan Gardner 2019-05-14 16:02:07 PDT
Fix flakey test fast/events/autoscroll-when-input-is-offscreen.html
Comment 1 Megan Gardner 2019-05-14 16:03:37 PDT
Created attachment 369904 [details]
Patch
Comment 2 Megan Gardner 2019-05-14 16:04:25 PDT
Created attachment 369905 [details]
Patch
Comment 3 Megan Gardner 2019-05-14 16:04:53 PDT
<rdar://problem/50306931>
Comment 4 Tim Horton 2019-05-14 16:39:02 PDT
Comment on attachment 369905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369905&action=review

> LayoutTests/ChangeLog:9
> +        Espeically in debug, scrolling is slow enough that we need to allow for a

"Especially"

> LayoutTests/ChangeLog:10
> +        presentation update. Then we can be sure that the page has finished scrolling

"Scrolling is slow enough" isn't the right phrase. "Programmatic scrolls are included in the transaction and you want to ensure that they've been applied" is better.

> LayoutTests/fast/events/autoscroll-when-input-is-offscreen.html:22
>          var programaticScroll = 500;

Two "m"s in programmatic.
Comment 5 Megan Gardner 2019-05-14 16:42:23 PDT
Created attachment 369908 [details]
Patch
Comment 6 EWS Watchlist 2019-05-14 17:22:46 PDT
Comment on attachment 369908 [details]
Patch

Attachment 369908 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12192748

New failing tests:
fast/events/autoscroll-when-input-is-offscreen.html
Comment 7 EWS Watchlist 2019-05-14 17:22:47 PDT
Created attachment 369911 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 8 Megan Gardner 2019-05-14 17:33:53 PDT
Created attachment 369912 [details]
Patch
Comment 9 WebKit Commit Bot 2019-05-14 21:00:11 PDT
Comment on attachment 369912 [details]
Patch

Clearing flags on attachment: 369912

Committed r245316: <https://trac.webkit.org/changeset/245316>
Comment 10 WebKit Commit Bot 2019-05-14 21:00:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Alexey Proskuryakov 2019-05-15 14:34:18 PDT
*** Bug 197379 has been marked as a duplicate of this bug. ***