Summary: | [WHLSL] parseEffectfulAssignment should not call parseCallExpression directly | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||||||
Component: | WebGPU | Assignee: | Robin Morisset <rmorisset> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, mmaxfield, rmorisset, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Robin Morisset
2019-05-14 12:04:33 PDT
Created attachment 369879 [details]
Patch
I think we can test this patch. If the program fails to parse, the JS call should return null. Comment on attachment 369879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369879&action=review > Source/WebCore/ChangeLog:9 > + I've already fixed the grammar, this patch is fixing the parser. Let's link to the associated grammar fix and spec fix. Created attachment 369882 [details]
Patch for landing
Added link in the changelog.
Comment on attachment 369882 [details] Patch for landing Rejecting attachment 369882 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 369882, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=369882&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=197890&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 369882 from bug 197890. Fetching: https://bugs.webkit.org/attachment.cgi?id=369882 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog patch: **** malformed patch at line 22: Video frame resizing should be using Trim patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/12190332 Created attachment 369884 [details]
Patch for landing
Comment on attachment 369884 [details] Patch for landing Clearing flags on attachment: 369884 Committed r245302: <https://trac.webkit.org/changeset/245302> All reviewed patches have been landed. Closing bug. |