Summary: | <input type=color> should have box-sizing: border-box in UA stylesheet | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Pieters (:zcorpan) <zcorpan> | ||||||||
Component: | Layout and Rendering | Assignee: | zsun | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | akeerthi, bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, ntim, pdr, simon.fraser, timothy, webkit-bug-importer, wenson_hsieh, zalan, zsun | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Simon Pieters (:zcorpan)
2019-05-14 06:17:13 PDT
Created attachment 457614 [details]
Patch
Comment on attachment 457614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457614&action=review > Source/WebCore/rendering/RenderTheme.cpp:1235 > + return "input[type=\"color\"] { appearance: auto; width: 50px; height: 27px; box-sizing: border-box; outline: none; } "_s; How were the new width/height values determined? Created attachment 458258 [details]
Patch
Comment on attachment 458258 [details] Patch Looks like mac-wk1 needs a special baseline. Can you add special test expectations for mac-wk1? Looks like this is just because <input type=color> is disabled with WebKitLegacy: https://webkit-search.igalia.com/webkit/source/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml#425-437 Created attachment 458780 [details]
[fast-cq] Patch
Comment on attachment 458780 [details]
[fast-cq] Patch
r=me
Committed r293830 (250303@main): <https://commits.webkit.org/250303@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458780 [details]. |