Bug 197878 – <input type=color> should have box-sizing: border-box in UA stylesheet

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Simon Pieters (:zcorpan)]

Spec issue: https://github.com/whatwg/html/issues/4281

Spec change: https://github.com/whatwg/html/pull/4143/files#diff-36cd38f49b9afa08222c0dc9ebfe35ebR112423

Test:
html/rendering/non-replaced-elements/form-controls/button-style.html
in
https://github.com/web-platform-tests/wpt/pull/14824

Created attachment 457614 [details]
Patch

[Aditya Keerthi]

Comment on attachment 457614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457614&action=review

> Source/WebCore/rendering/RenderTheme.cpp:1235
> +    return "input[type=\"color\"] { appearance: auto; width: 50px; height: 27px; box-sizing: border-box; outline: none; } "_s;

How were the new width/height values determined?

Created attachment 458258 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/92396765>

[Tim Nguyen (:ntim)]

Comment on attachment 458258 [details]
Patch

Looks like mac-wk1 needs a special baseline.

Can you add special test expectations for mac-wk1?

Looks like this is just because <input type=color> is disabled with WebKitLegacy: https://webkit-search.igalia.com/webkit/source/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml#425-437

Created attachment 458780 [details]
[fast-cq] Patch

[Tim Nguyen (:ntim)]

Comment on attachment 458780 [details]
[fast-cq] Patch

r=me

[EWS]

Committed r293830 (250303@main): <https://commits.webkit.org/250303@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458780 [details].