Bug 19787

Summary: create most arrays from values in registers rather than with multiple put operations
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch
none
patch, updated for TOT and revised based on Geoff's feedback oliver: review+

Darin Adler
Reported 2008-06-26 23:44:33 PDT
This is a speed optimization. It's a new opcode.
Attachments
patch (8.62 KB, patch)
2008-06-26 23:48 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch (8.66 KB, patch)
2008-06-26 23:49 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch, updated for TOT and revised based on Geoff's feedback (14.15 KB, patch)
2008-06-27 21:35 PDT, Darin Adler 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2008-06-26 23:48:24 PDT
Created attachment 21968 [details] patch
Darin Adler
Comment 2 2008-06-26 23:49:32 PDT
Created attachment 21969 [details] patch Forgot to include the SunSpider speed-up figure in the ChangeLog.
Darin Adler
Comment 3 2008-06-27 21:35:39 PDT
Created attachment 21981 [details] patch, updated for TOT and revised based on Geoff's feedback
Oliver Hunt
Comment 4 2008-06-28 00:36:50 PDT
Comment on attachment 21981 [details] patch, updated for TOT and revised based on Geoff's feedback r=me, but the removal of the in place constructors should be a separate patch. However, r=me on removing them as well :D
Cameron Zwarich (cpst)
Comment 5 2008-06-28 01:49:14 PDT
You should also probably update the op_new_array documentation.
Darin Adler
Comment 6 2008-06-28 22:25:37 PDT
http://trac.webkit.org/changeset/34851
Note You need to log in before you can comment on or make changes to this bug.