Bug 19787

Summary: create most arrays from values in registers rather than with multiple put operations
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch
none
patch, updated for TOT and revised based on Geoff's feedback oliver: review+

Description Darin Adler 2008-06-26 23:44:33 PDT
This is a speed optimization.

It's a new opcode.
Comment 1 Darin Adler 2008-06-26 23:48:24 PDT
Created attachment 21968 [details]
patch
Comment 2 Darin Adler 2008-06-26 23:49:32 PDT
Created attachment 21969 [details]
patch

Forgot to include the SunSpider speed-up figure in the ChangeLog.
Comment 3 Darin Adler 2008-06-27 21:35:39 PDT
Created attachment 21981 [details]
patch, updated for TOT and revised based on Geoff's feedback
Comment 4 Oliver Hunt 2008-06-28 00:36:50 PDT
Comment on attachment 21981 [details]
patch, updated for TOT and revised based on Geoff's feedback

r=me, but the removal of the in place constructors should be a separate patch.  However, r=me on removing them as well :D
Comment 5 Cameron Zwarich (cpst) 2008-06-28 01:49:14 PDT
You should also probably update the op_new_array documentation.
Comment 6 Darin Adler 2008-06-28 22:25:37 PDT
http://trac.webkit.org/changeset/34851