Bug 197801

Summary: A service worker instance should be terminated when its SWServer is destroyed
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2019-05-10 15:07:10 PDT 
A service worker instance should be terminated when its SWServer is destroyed
Comment 1 youenn fablet 2019-05-10 15:30:21 PDT 
<rdar://problem/50587270>
Comment 2 youenn fablet 2019-05-10 15:33:34 PDT 
Created attachment 369608 [details]
Patch
Comment 3 WebKit Commit Bot 2019-05-10 16:33:44 PDT 
Comment on attachment 369608 [details]
Patch

Clearing flags on attachment: 369608

Committed r245200: <https://trac.webkit.org/changeset/245200>
Comment 4 WebKit Commit Bot 2019-05-10 16:33:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Geoffrey Garen 2019-05-13 14:32:09 PDT 
What mechanism prevents two concurrent but independent sessions from sharing a service worker?
Comment 6 Chris Dumez 2019-05-13 15:08:04 PDT 
(In reply to Geoffrey Garen from comment #5)
> What mechanism prevents two concurrent but independent sessions from sharing
> a service worker?

We use a different SWServer instance per session ID. Service worker instances are owned by each SWServer instance so I do not believe different session can share service workers.