Summary: | Add WKWebViewConfiguration._canShowWhileLocked SPI | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ggaren, thorton, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2019-05-10 08:57:33 PDT
Created attachment 369552 [details]
Patch
Created attachment 369555 [details]
Patch
Comment on attachment 369555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369555&action=review > Source/WebKit/Platform/mac/LayerHostingContext.mm:62 > + kCAContextSecure: canShowWhileLocked ? @YES : @NO, @(canShowWhileLocked) > Source/WebKit/Platform/mac/LayerHostingContext.mm:71 > + kCAContextCIFilterBehavior : @"ignore", Pretty sure these are all Mac paths and don’t support this option. But maybe the symbol is there and the extra key will be ignored? (In reply to Tim Horton from comment #4) > Comment on attachment 369555 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369555&action=review > > > Source/WebKit/Platform/mac/LayerHostingContext.mm:62 > > + kCAContextSecure: canShowWhileLocked ? @YES : @NO, > > @(canShowWhileLocked) > > > Source/WebKit/Platform/mac/LayerHostingContext.mm:71 > > + kCAContextCIFilterBehavior : @"ignore", > > Pretty sure these are all Mac paths and don’t support this option. But maybe > the symbol is there and the extra key will be ignored? To be clear I meant the one you added not the one that got quoted Created attachment 369568 [details]
Patch
Comment on attachment 369568 [details] Patch Clearing flags on attachment: 369568 Committed r245183: <https://trac.webkit.org/changeset/245183> All reviewed patches have been landed. Closing bug. |