Bug 197777

Summary: Add WKWebViewConfiguration._canShowWhileLocked SPI
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2019-05-10 08:57:33 PDT
Add WKWebViewConfiguration._canShowWhileLocked SPI.
Comment 1 Chris Dumez 2019-05-10 08:57:50 PDT
<rdar://problem/50065100>
Comment 2 Chris Dumez 2019-05-10 09:12:05 PDT
Created attachment 369552 [details]
Patch
Comment 3 Chris Dumez 2019-05-10 09:38:51 PDT
Created attachment 369555 [details]
Patch
Comment 4 Tim Horton 2019-05-10 09:45:49 PDT
Comment on attachment 369555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369555&action=review

> Source/WebKit/Platform/mac/LayerHostingContext.mm:62
> +        kCAContextSecure: canShowWhileLocked ? @YES : @NO,

@(canShowWhileLocked)

> Source/WebKit/Platform/mac/LayerHostingContext.mm:71
> +        kCAContextCIFilterBehavior :  @"ignore",

Pretty sure these are all Mac paths and don’t support this option. But maybe the symbol is there and the extra key will be ignored?
Comment 5 Tim Horton 2019-05-10 09:46:28 PDT
(In reply to Tim Horton from comment #4)
> Comment on attachment 369555 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369555&action=review
> 
> > Source/WebKit/Platform/mac/LayerHostingContext.mm:62
> > +        kCAContextSecure: canShowWhileLocked ? @YES : @NO,
> 
> @(canShowWhileLocked)
> 
> > Source/WebKit/Platform/mac/LayerHostingContext.mm:71
> > +        kCAContextCIFilterBehavior :  @"ignore",
> 
> Pretty sure these are all Mac paths and don’t support this option. But maybe
> the symbol is there and the extra key will be ignored?

To be clear I meant the one you added not the one that got quoted
Comment 6 Chris Dumez 2019-05-10 10:50:19 PDT
Created attachment 369568 [details]
Patch
Comment 7 WebKit Commit Bot 2019-05-10 11:52:12 PDT
Comment on attachment 369568 [details]
Patch

Clearing flags on attachment: 369568

Committed r245183: <https://trac.webkit.org/changeset/245183>
Comment 8 WebKit Commit Bot 2019-05-10 11:52:14 PDT
All reviewed patches have been landed.  Closing bug.