Summary: | [iOS] Lazily request keyboard on first hardware keydown when a non-editable element is focused | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, ews-watchlist, megan_gardner, pvollan, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | iPhone / iPad | ||||||||||
OS: | iOS 12 | ||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=197745 https://bugs.webkit.org/show_bug.cgi?id=199807 |
||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 190571 | ||||||||||
Attachments: |
|
Description
Daniel Bates
2019-05-09 11:27:24 PDT
Created attachment 369511 [details]
Patch
Comment on attachment 369511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369511&action=review > Source/WebKit/ChangeLog:10 > + Be even lazier. We only need to create a keyboard if an editable element is focused or on > + the first hardware keydown when a non-editable element is focused. Note that we already do the former. This patch is about the latter. Created attachment 369512 [details]
Patch
Attachment 369512 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1673: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 369512 [details]
Patch
r=me
Created attachment 369519 [details]
To Land
Comment on attachment 369519 [details] To Land Clearing flags on attachment: 369519 Committed r245154: <https://trac.webkit.org/changeset/245154> All reviewed patches have been landed. Closing bug. |