Bug 197738

Summary: pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html is a timeout
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Description Antoine Quint 2019-05-09 06:59:17 PDT
pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html is a timeout
Comment 1 Antoine Quint 2019-05-09 07:04:28 PDT
Created attachment 369490 [details]
Patch
Comment 2 Antoine Quint 2019-05-09 07:04:33 PDT
<rdar://problem/50588613>
Comment 3 Antti Koivisto 2019-05-09 07:10:47 PDT
Comment on attachment 369490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369490&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:345
> +        m_activeTouchActions = scrollingCoordinatorProxy.activeTouchActionsForTouchIdentifier(*touchIdentifier);

Should this be cleared when the scrolling fully finishes? Seem bet weird that it can stay non-empty long past the gesture.
Comment 4 Antoine Quint 2019-05-09 07:16:03 PDT
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 369490 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369490&action=review
> 
> > Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:345
> > +        m_activeTouchActions = scrollingCoordinatorProxy.activeTouchActionsForTouchIdentifier(*touchIdentifier);
> 
> Should this be cleared when the scrolling fully finishes? Seem bet weird
> that it can stay non-empty long past the gesture.

Fixing this in commit.
Comment 5 Antoine Quint 2019-05-09 07:16:54 PDT
Committed r245134: <https://trac.webkit.org/changeset/245134>