Bug 197728

Summary: Guard long press link preview with a USE macro rather than complicated includes
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
wenson_hsieh: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews212 for win-future none

Dean Jackson
Reported 2019-05-08 17:45:38 PDT
Guard long press link preview with a USE macro rather than complicated includes
Attachments
Patch (8.48 KB, patch)
2019-05-08 17:50 PDT, Dean Jackson 		wenson_hsieh: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews212 for win-future (13.65 MB, application/zip)
2019-05-08 20:51 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-08 17:46:15 PDT
<rdar://problem/50604700>
Dean Jackson
Comment 2 2019-05-08 17:50:31 PDT
Created attachment 369452 [details] Patch
EWS Watchlist
Comment 3 2019-05-08 20:51:07 PDT
Comment on attachment 369452 [details] Patch Attachment 369452 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12139527 New failing tests: editing/selection/doubleclick-crash.html
EWS Watchlist
Comment 4 2019-05-08 20:51:09 PDT
Created attachment 369458 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Dean Jackson
Comment 5 2019-05-09 12:46:53 PDT
Committed r245153: <https://trac.webkit.org/changeset/245153>
Dean Jackson
Comment 6 2019-05-09 12:47:05 PDT
Committed r245153: <https://trac.webkit.org/changeset/245153>
Note You need to log in before you can comment on or make changes to this bug.