Bug 197710

Summary: Pass insertTextAsync options as a struct
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 197632    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Daniel Bates
Reported 2019-05-08 14:08:16 PDT
WebPageProxy::insertTextAsync() is becoming unwieldy to work with given the large number of optional arguments that can be passed and I am eyeing to pass another optional argument towards fixing bug #197632. Let's pass a struct of options instead.
Attachments
Patch (23.50 KB, patch)
2019-05-08 14:37 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (23.56 KB, patch)
2019-05-08 15:09 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (23.57 KB, patch)
2019-05-08 15:14 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-05-08 14:37:03 PDT
Created attachment 369424 [details] Patch
Daniel Bates
Comment 2 2019-05-08 15:09:14 PDT
Created attachment 369427 [details] Patch
Daniel Bates
Comment 3 2019-05-08 15:14:11 PDT
Created attachment 369431 [details] Patch
Brent Fulgham
Comment 4 2019-05-08 15:25:30 PDT
Comment on attachment 369431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369431&action=review Looks like a nice simplification. r=me. > Source/WebKit/Shared/Cocoa/InsertTextOptions.h:36 > + EditingRangeIsRelativeTo editingRangeIsRelativeTo { EditingRangeIsRelativeTo::EditableRoot }; It might be more space-efficient to move the booleans to the bottom of the struct.
Daniel Bates
Comment 5 2019-05-08 15:47:39 PDT
(In reply to Brent Fulgham from comment #4) > Comment on attachment 369431 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369431&action=review > > Looks like a nice simplification. r=me. > > > Source/WebKit/Shared/Cocoa/InsertTextOptions.h:36 > > + EditingRangeIsRelativeTo editingRangeIsRelativeTo { EditingRangeIsRelativeTo::EditableRoot }; > > It might be more space-efficient to move the booleans to the bottom of the > struct. It shouldn't make a difference. sizeof(bool) == 1 == sizeof(uint8_t).
Daniel Bates
Comment 6 2019-05-08 15:48:35 PDT
Comment on attachment 369431 [details] Patch Clearing flags on attachment: 369431 Committed r245073: <https://trac.webkit.org/changeset/245073>
Daniel Bates
Comment 7 2019-05-08 15:48:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-05-08 15:51:40 PDT
<rdar://problem/50600263>
Note You need to log in before you can comment on or make changes to this bug.