Summary: | Pass insertTextAsync options as a struct | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 197632 | ||||||||||
Attachments: |
|
Description
Daniel Bates
2019-05-08 14:08:16 PDT
Created attachment 369424 [details]
Patch
Created attachment 369427 [details]
Patch
Created attachment 369431 [details]
Patch
Comment on attachment 369431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369431&action=review Looks like a nice simplification. r=me. > Source/WebKit/Shared/Cocoa/InsertTextOptions.h:36 > + EditingRangeIsRelativeTo editingRangeIsRelativeTo { EditingRangeIsRelativeTo::EditableRoot }; It might be more space-efficient to move the booleans to the bottom of the struct. (In reply to Brent Fulgham from comment #4) > Comment on attachment 369431 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369431&action=review > > Looks like a nice simplification. r=me. > > > Source/WebKit/Shared/Cocoa/InsertTextOptions.h:36 > > + EditingRangeIsRelativeTo editingRangeIsRelativeTo { EditingRangeIsRelativeTo::EditableRoot }; > > It might be more space-efficient to move the booleans to the bottom of the > struct. It shouldn't make a difference. sizeof(bool) == 1 == sizeof(uint8_t). Comment on attachment 369431 [details] Patch Clearing flags on attachment: 369431 Committed r245073: <https://trac.webkit.org/changeset/245073> All reviewed patches have been landed. Closing bug. |