Summary: | Event region generation needs to know about backing-sharing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | Compositing | Assignee: | Antti Koivisto <koivisto> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, commit-queue, koivisto, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 197561 | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2019-05-08 10:01:02 PDT
For now I'll mark this as a test failure in TestExpectations. Created attachment 369547 [details]
patch
Created attachment 369548 [details]
patch
Comment on attachment 369548 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=369548&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:1497 > + for (auto& layerWeakPtr : m_backingSharingLayers) > + layerWeakPtr->paintLayerContents(nullContext, paintingInfo, paintFlags); Do you need to null check layerWeakPtr here? > Do you need to null check layerWeakPtr here?
Nah, weakptrs in this code are just for safety, the logic should guarantee they won't be null here.
Comment on attachment 369548 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=369548&action=review >> Source/WebCore/rendering/RenderLayerBacking.cpp:1497 >> + layerWeakPtr->paintLayerContents(nullContext, paintingInfo, paintFlags); > > Do you need to null check layerWeakPtr here? No, we think that's a correctness bug and are OK with a null-deref crash. However, this code will be wrong when the sharing layers have transforms. Please file a follow-up bug to fix that. You'll need to use something like I'm adding in bug 197692. Comment on attachment 369548 [details] patch Clearing flags on attachment: 369548 Committed r245175: <https://trac.webkit.org/changeset/245175> All reviewed patches have been landed. Closing bug. |