Bug 197677

Summary: macro assembler code-pointer tagging has its arguments backwards
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, saam, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
msaboff: review+
patch for landing
saam: commit-queue-
patch for landing none

Keith Miller
Reported 2019-05-07 16:14:50 PDT
Normally, we have the macro assembler code put the destination as the right-most parameter. the code-pointer tagging has the destination on the left.
Attachments
patch (9.81 KB, patch)
2019-05-13 12:53 PDT, Saam Barati 		msaboff: review+
DetailsFormatted DiffDiff
patch for landing (10.46 KB, patch)
2019-05-13 13:07 PDT, Saam Barati 		saam: commit-queue-
DetailsFormatted DiffDiff
patch for landing (10.61 KB, patch)
2019-05-13 14:01 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-05-07 16:51:11 PDT
*** Bug 197422 has been marked as a duplicate of this bug. ***
Saam Barati
Comment 2 2019-05-13 12:53:07 PDT
Created attachment 369765 [details] patch
Michael Saboff
Comment 3 2019-05-13 13:00:22 PDT
Comment on attachment 369765 [details] patch r=me, but it looks like you need to fix mips.
Saam Barati
Comment 4 2019-05-13 13:07:07 PDT
Created attachment 369769 [details] patch for landing
Tadeu Zagallo
Comment 5 2019-05-13 13:50:24 PDT
Comment on attachment 369769 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=369769&action=review > Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:980 > ALWAYS_INLINE void tagPtr(RegisterID, PtrTag) { } Shouldn't this be flipped as well?
Saam Barati
Comment 6 2019-05-13 14:00:48 PDT
Comment on attachment 369769 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=369769&action=review >> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:980 >> ALWAYS_INLINE void tagPtr(RegisterID, PtrTag) { } > > Shouldn't this be flipped as well? yup
Saam Barati
Comment 7 2019-05-13 14:01:50 PDT
Created attachment 369779 [details] patch for landing
WebKit Commit Bot
Comment 8 2019-05-13 14:34:49 PDT
Comment on attachment 369779 [details] patch for landing Clearing flags on attachment: 369779 Committed r245251: <https://trac.webkit.org/changeset/245251>
WebKit Commit Bot
Comment 9 2019-05-13 14:34:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-05-13 14:35:19 PDT
<rdar://problem/50739261>
Note You need to log in before you can comment on or make changes to this bug.