Bug 197672

Summary: WTF::TimingScope should show the total duration and not just the mean
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: Web Template FrameworkAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews212 for win-future none

Robin Morisset
Reported 2019-05-07 12:57:39 PDT
I found myself frequently multiplying the mean duration by the number of calls to find the total time spent in a function. It is trivial to just have TimingScope show this information.
Attachments
Patch (1.30 KB, patch)
2019-05-07 12:59 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews212 for win-future (13.63 MB, application/zip)
2019-05-07 19:58 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-05-07 12:59:02 PDT
Created attachment 369317 [details] Patch trivial patch.
EWS Watchlist
Comment 2 2019-05-07 19:58:24 PDT
Comment on attachment 369317 [details] Patch Attachment 369317 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12129493 New failing tests: http/tests/css/filters-on-iframes.html
EWS Watchlist
Comment 3 2019-05-07 19:58:26 PDT
Created attachment 369352 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Robin Morisset
Comment 4 2019-05-08 10:52:11 PDT
Comment on attachment 369317 [details] Patch The windows bot appears red in general, it is not related to this patch.
WebKit Commit Bot
Comment 5 2019-05-08 11:18:47 PDT
Comment on attachment 369317 [details] Patch Clearing flags on attachment: 369317 Committed r245061: <https://trac.webkit.org/changeset/245061>
WebKit Commit Bot
Comment 6 2019-05-08 11:18:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-05-08 11:19:26 PDT
<rdar://problem/50588584>
Note You need to log in before you can comment on or make changes to this bug.