Bug 197668 – Add option to build-webkit to control whether or not XCBuild is used

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Keith Rollin]

Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not. Also update build-webkit and the makefiles with the foundation for automatically using XCBuild when the conditions allow it. This latter facility is currently turned off until Xcode fully supports building WebKit with XCBuild.

[Radar WebKit Bug Importer]

<rdar://problem/50549728>

[Keith Rollin]

Created attachment 369309 [details]
Patch

[Tim Horton]

Comment on attachment 369309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369309&action=review

> Tools/Scripts/build-webkit:76
> +my $xcbuild = -1;

undef is also an option

> Makefile.shared:48
> +	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()')

😲

[Keith Rollin]

(In reply to Tim Horton from comment #3)
> Comment on attachment 369309 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369309&action=review
> 
> > Tools/Scripts/build-webkit:76
> > +my $xcbuild = -1;
> 
> undef is also an option

Thanks. My perl is a bit rusty and I'd forgotten this. I actually did a web search for the idiomatic approach to tri-state variables, but didn't turn that one up.

> 
> > Makefile.shared:48
> > +	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()')
> 
> 😲

I don't understand what you mean by that.

[Tim Horton]

(In reply to Keith Rollin from comment #4)
> (In reply to Tim Horton from comment #3)
> > Comment on attachment 369309 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=369309&action=review
> > 
> > > Tools/Scripts/build-webkit:76
> > > +my $xcbuild = -1;
> > 
> > undef is also an option
> 
> Thanks. My perl is a bit rusty and I'd forgotten this. I actually did a web
> search for the idiomatic approach to tri-state variables, but didn't turn
> that one up.

OK!

> > 
> > > Makefile.shared:48
> > > +	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()')
> > 
> > 😲
> 
> I don't understand what you mean by that.

Nothing actionable, just pretend that's what my face looked like while reading.

[Alex Christensen]

Comment on attachment 369309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369309&action=review

>>> Makefile.shared:48
>>> +	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()')
>> 
>> 😲
> 
> I don't understand what you mean by that.

This is the most duct tape line of code I've ever seen.

[Keith Rollin]

Created attachment 369318 [details]
Do the undef thing.

[Keith Rollin]

(In reply to Alex Christensen from comment #6)
> Comment on attachment 369309 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369309&action=review
> 
> >>> Makefile.shared:48
> >>> +	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()')
> >> 
> >> 😲
> > 
> > I don't understand what you mean by that.
> 
> This is the most duct tape line of code I've ever seen.

What would you prefer?

[Alex Christensen]

CMake

[WebKit Commit Bot]

Comment on attachment 369318 [details]
Do the undef thing.

Clearing flags on attachment: 369318

Committed r245037: <https://trac.webkit.org/changeset/245037>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Sam Sneddon [:gsnedders]]

*** Bug 198589 has been marked as a duplicate of this bug. ***