Summary: | Add option to build-webkit to control whether or not XCBuild is used | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||||
Component: | Tools / Tests | Assignee: | Keith Rollin <krollin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, ap, commit-queue, dbates, jbedard, lforschler, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Keith Rollin
2019-05-07 11:59:19 PDT
Created attachment 369309 [details]
Patch
Comment on attachment 369309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369309&action=review > Tools/Scripts/build-webkit:76 > +my $xcbuild = -1; undef is also an option > Makefile.shared:48 > + CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()') 😲 (In reply to Tim Horton from comment #3) > Comment on attachment 369309 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369309&action=review > > > Tools/Scripts/build-webkit:76 > > +my $xcbuild = -1; > > undef is also an option Thanks. My perl is a bit rusty and I'd forgotten this. I actually did a web search for the idiomatic approach to tri-state variables, but didn't turn that one up. > > > Makefile.shared:48 > > + CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()') > > 😲 I don't understand what you mean by that. (In reply to Keith Rollin from comment #4) > (In reply to Tim Horton from comment #3) > > Comment on attachment 369309 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=369309&action=review > > > > > Tools/Scripts/build-webkit:76 > > > +my $xcbuild = -1; > > > > undef is also an option > > Thanks. My perl is a bit rusty and I'd forgotten this. I actually did a web > search for the idiomatic approach to tri-state variables, but didn't turn > that one up. OK! > > > > > Makefile.shared:48 > > > + CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()') > > > > 😲 > > I don't understand what you mean by that. Nothing actionable, just pretend that's what my face looked like while reading. Comment on attachment 369309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369309&action=review >>> Makefile.shared:48 >>> + CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()') >> >> 😲 > > I don't understand what you mean by that. This is the most duct tape line of code I've ever seen. Created attachment 369318 [details]
Do the undef thing.
(In reply to Alex Christensen from comment #6) > Comment on attachment 369309 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369309&action=review > > >>> Makefile.shared:48 > >>> + CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()') > >> > >> 😲 > > > > I don't understand what you mean by that. > > This is the most duct tape line of code I've ever seen. What would you prefer? CMake Comment on attachment 369318 [details] Do the undef thing. Clearing flags on attachment: 369318 Committed r245037: <https://trac.webkit.org/changeset/245037> All reviewed patches have been landed. Closing bug. *** Bug 198589 has been marked as a duplicate of this bug. *** |